Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge options to GHRepository #567

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Conversation

jberglund-BSFT
Copy link
Contributor

As far as I can tell the merge options are currently only available on the create repo. This will add the merge options on the get repo and allows for changing the value post-creation.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed, then we can merge.

@jberglund-BSFT
Copy link
Contributor Author

jberglund-BSFT commented Oct 8, 2019

@bitwiseman Sure, how do you come up with the hashes for the wiremock templates?

@bitwiseman
Copy link
Member

bitwiseman commented Oct 8, 2019

@jberglund-BSFT
See the Contributing.md for instructions on recording wiremock data.
I've invited you to https://github.com/orgs/github-api-test-org so you can create data using that org.

@jberglund-BSFT
Copy link
Contributor Author

@bitwiseman I've added some tests

@bitwiseman bitwiseman merged commit 5990f5a into hub4j:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants